Mobile column view redux #1720
Draft
Mobile column view redux #1720
+329
−256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ined-scrolling Mobile / Column view redux / Contained scrolling
* main: (579 commits) Add test coverage for the require_unauthenticated_access redirect Explicitly use main_app for URL helpers Bump fizzy-saas Make list style same for every indentation Update Gemfile.saas.lock Need to use `has*Target` to check for optional static targets to prevent console errors Turn `#theme` into a proper setter Prefer normal if/else conditional Bump rails version to remove svg renderer patch (#2081) Test that sign in respects single tenant state Bump fizzy-saas to set config option Scope the config option Update namespacing & naming Naming Don't need to call this out Use initializer to configure tenant mode Single tenant by default & update tests Explain that the upload URL is account-scope Allow direct uploads via API Storage: ignore jobs for now-deleted targets ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes to how the column view works:
Since this touches the application layout, trays, and the main column layout, I want to get this on beta first so we can put it through the paces. Most likely problems I can see cropping up are unexpected scroll containers.