Fix MetaManager::wipe()
#175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
and-cb
force-pushed
the
andrea/fix-wipe
branch
2 times, most recently
from
90e4dd2 to
e5075e6
Compare
`wipe()` was not correctly erasing the metadata, mostly because it was filling with zeros the incorrect memory range (`[size..]` instead of `[..size]`). This made opening existing databases using `wipe(true)` fail with an error because the number of pages specified in the metadata didn't correspond with the number of pages in the data file. This fixes the problem, and also adds a test to prevent similar issues from occurring in the future.
and-cb
force-pushed
the
andrea/fix-wipe
branch
from
e5075e6 to
8923168
Compare
jjtny1
approved these changes
Oct 16, 2025
|
Review Error for jjtny1 @ 2025-10-16 16:13:42 UTC |
jjtny1
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wipe()was not correctly erasing the metadata, mostly because it was filling with zeros the incorrect memory range ([size..]instead of[..size]). This made opening existing databases usingwipe(true)fail with an error because the number of pages specified in the metadata didn't correspond with the number of pages in the data file.This fixes the problem, and also adds a test to prevent similar issues from occurring in the future.