fix: resolve unreachable code and infinite loop in release pagination #663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed unreachable code that could cause infinite loop when searching for releases with specific tag prefixes.
What was wrong:
The code had an impossible condition - it checked if TagPrefix was empty, then if it wasn't empty, and then had a third check that could never run because the first two already covered everything.
This meant that when looking for a release with a specific prefix (like "op-node"), if that release didn't exist, the code would keep searching forever instead of stopping when it ran out of pages.
What changed:
Moved the "no more pages" check to where it actually makes sense - inside the prefix search logic. Now it properly stops when either finding the release or running out of pages to check.
Why it matters:
Prevents the dependency updater from getting stuck in an endless loop when a tagged release doesn't exist in a repository.