Skip to content

Conversation

@futreall
Copy link

Fixed unreachable code that could cause infinite loop when searching for releases with specific tag prefixes.

What was wrong:
The code had an impossible condition - it checked if TagPrefix was empty, then if it wasn't empty, and then had a third check that could never run because the first two already covered everything.

This meant that when looking for a release with a specific prefix (like "op-node"), if that release didn't exist, the code would keep searching forever instead of stopping when it ran out of pages.

What changed:
Moved the "no more pages" check to where it actually makes sense - inside the prefix search logic. Now it properly stops when either finding the release or running out of pages to check.

Why it matters:
Prevents the dependency updater from getting stuck in an endless loop when a tagged release doesn't exist in a repository.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants