geth: respect HOST_IP env; remove override that broke --nat=extip #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entrypoint hard-set HOST_IP="" which overwrote any environment-provided value. As a result, the conditional that appends --nat=extip:$HOST_IP never executed, making it impossible to advertise a public IP even when HOST_IP was supplied via env. This fixes the issue by removing the overriding assignment and adding a clarifying comment to set HOST_IP via environment. Now, when HOST_IP is non-empty, --nat=extip is correctly applied; when unset/empty, it’s omitted.