Get ready for ownership changeover #401

stevieraykatz · 2025-08-13T20:44:54Z

Basenames ecosystem multisig is changing ownership. 6 previous signers are being swapped for 7 new signers.

cb-heimdall · 2025-08-13T20:44:58Z

🟡 Heimdall Review Status

Requirement Status More Info

Reviews

🟡 1/2

Denominator calculation

Show calculation

1 if user is bot 0

1 if user is external 0

2 if repo is sensitive 0

From .codeflow.yml 2

Additional review requirements

Show calculation

Max	0

0

From CODEOWNERS 0

Global minimum 0

Max 2

2

1 if commit is unverified 1

Sum 3

…th ownership management

github-actions · 2025-08-15T19:09:34Z

❌ Upgrade Structure Validation Failed

The validation check found issues with your upgrade folder structure. Please ensure:

All upgrade folders have a validations/ subdirectory
Each validations/ folder contains at least one config file:
- base-nested.json (for Coinbase validation)
- base-sc.json (for Base SC validation)
- op.json (for OP validation)
All JSON files are valid and follow the correct schema

Please check the CI logs above for specific error details and fix the issues before merging.

📖 See the validation documentation for more details.

stevieraykatz · 2025-08-15T21:07:14Z

❌ Upgrade Structure Validation Failed

The validation check found issues with your upgrade folder structure. Please ensure:

All upgrade folders have a validations/ subdirectory

Each validations/ folder contains at least one config file:

base-nested.json (for Coinbase validation)

base-sc.json (for Base SC validation)

op.json (for OP validation)

All JSON files are valid and follow the correct schema

Please check the CI logs above for specific error details and fix the issues before merging.

📖 See the validation documentation for more details.

Not required for this PR.

github-actions · 2025-08-18T19:58:12Z

❌ Upgrade Structure Validation Failed

The validation check found issues with your upgrade folder structure. Please ensure:

All upgrade folders have a validations/ subdirectory
Each validations/ folder contains at least one config file:
- base-nested.json (for Coinbase validation)
- base-sc.json (for Base SC validation)
- op.json (for OP validation)
All JSON files are valid and follow the correct schema

Please check the CI logs above for specific error details and fix the issues before merging.

📖 See the validation documentation for more details.

github-actions · 2025-08-19T18:53:41Z

❌ Upgrade Structure Validation Failed

The validation check found issues with your upgrade folder structure. Please ensure:

All upgrade folders have a validations/ subdirectory
Each validations/ folder contains at least one config file:
- base-nested.json (for Coinbase validation)
- base-sc.json (for Base SC validation)
- op.json (for OP validation)
All JSON files are valid and follow the correct schema

Please check the CI logs above for specific error details and fix the issues before merging.

📖 See the validation documentation for more details.

github-actions · 2025-08-19T19:24:08Z

❌ Upgrade Structure Validation Failed

The validation check found issues with your upgrade folder structure. Please ensure:

All upgrade folders have a validations/ subdirectory
Each validations/ folder contains at least one config file:
- base-nested.json (for Coinbase validation)
- base-sc.json (for Base SC validation)
- op.json (for OP validation)
All JSON files are valid and follow the correct schema

Please check the CI logs above for specific error details and fix the issues before merging.

📖 See the validation documentation for more details.

github-actions · 2025-08-19T21:33:37Z

❌ Upgrade Structure Validation Failed

The validation check found issues with your upgrade folder structure. Please ensure:

All upgrade folders have a validations/ subdirectory
Each validations/ folder contains at least one config file:
- base-nested.json (for Coinbase validation)
- base-sc.json (for Base SC validation)
- op.json (for OP validation)
All JSON files are valid and follow the correct schema

Please check the CI logs above for specific error details and fix the issues before merging.

📖 See the validation documentation for more details.

github-actions · 2025-09-10T21:50:25Z

❌ Upgrade Structure Validation Failed

The validation check found issues with your upgrade folder structure. Please ensure:

All upgrade folders have a validations/ subdirectory
Each validations/ folder contains at least one config file:
- base-nested.json (for Coinbase validation)
- base-sc.json (for Base SC validation)
- op.json (for OP validation)
All JSON files are valid and follow the correct schema

Please check the CI logs above for specific error details and fix the issues before merging.

📖 See the validation documentation for more details.

To disable the validation check please add a validation.yml file to your upgrade folder with 'disabled': true

eric-ships · 2025-10-02T18:20:15Z

mainnet/2025-08-13-safe-swap-owner/script/SwapOwner.s.sol

+        require(OWNERS_TO_REMOVE.length > 0);
+        address prevOwner = SENTINEL_OWNERS;
+        IGnosisSafe ownerSafe = IGnosisSafe(payable(OWNER_SAFE));
+


Should we check for owner changes here or is that pedantic?

require(keccak256(abi.encode(ownerSafe.getOwners())) == keccak256(abi.encode(EXISTING_OWNERS)), "Owner list changed");

eric-ships · 2025-10-02T18:21:45Z

mainnet/2025-08-13-safe-swap-owner/script/SwapOwner.s.sol

+            require(!ownerSafe.isOwner(OWNERS_TO_ADD[index]), "New owner already owner");
+            // Prevent duplicates
+            require(!expectedOwner[OWNERS_TO_ADD[index]], "Duplicate owner detected");
+


Should we check for whether the owner is the owner safe itself?

require(OWNERS_TO_ADD[i] != OWNER_SAFE, "Owner cannot be self");

Not a bad idea for next time!

eric-ships · 2025-10-02T18:23:01Z

mainnet/2025-08-13-safe-swap-owner/script/SwapOwner.s.sol

+        address prevOwner = SENTINEL_OWNERS;
+        IGnosisSafe ownerSafe = IGnosisSafe(payable(OWNER_SAFE));
+
+        for (uint256 i = OWNERS_TO_ADD.length; i > 0; i--) {


Curious why we're iterating backwards instead of forwards (i++) like with all the other for loops? Is this just a style thing?

Because owners are stored in a linked list

ilikesymmetry

Generally there's a lot of boilerplate here that doesn't seem necessary from my naive eyes. Feel like we could make our own separate repo for basenames multisig if we wanted and just optimize for our workflows so each new script diff is minimized to just the new thing we are doing for clarity. Would also let us share the same internals over time and make writing new scripts less risky inherently.

ilikesymmetry · 2025-10-03T00:33:30Z

mainnet/2025-08-13-safe-swap-owner/script/SwapOwner.s.sol

+    uint256 public immutable THRESHOLD;
+
+    constructor() {
+        OWNER_SAFE = vm.envAddress("OWNER_SAFE");


does this need to be env var? Would be easier to verify current owners are trying to remove if we had address in script

ilikesymmetry · 2025-10-03T00:36:00Z

mainnet/2025-08-13-safe-swap-owner/script/SwapOwner.s.sol

+        }
+    }
+
+    function _buildCalls() internal view override returns (IMulticall3.Call3Value[] memory) {


confused that I'm not seeing this used at all? Same for _postCheck? I'd normally expect the script to be something like:

function run() public { _buildCalls(); _postCheck(); }

look under the hood at the multisig script infra

ilikesymmetry · 2025-10-03T00:36:37Z

mainnet/2025-08-13-safe-swap-owner/script/SwapOwner.s.sol

+        OWNERS_TO_REMOVE = abi.decode(jsonData.parseRaw(".OwnersToRemove"), (address[]));
+    }
+
+    function setUp() public {


would appreciate some more commenting to make it easier to skim and orient on the intent of each section to make it easier to verify we're doing what we think we want

For instance, I cannot tell easily why we are doing all these loops vs just simply:

calls = _buildCalls(); execute(calls); postCheck();

get ready for ownership changeover

c6f04eb

Update script for total number of signatures changes, pull in repo wi…

5dd17d8

…th ownership management

base deleted a comment from github-actions bot Aug 15, 2025

stevieraykatz added 2 commits August 18, 2025 12:55

Add newest signers address

f2df8e7

Fix duplicated address in .env

c6f15b0

Update script

6801f38

Refactor to use appropriate linked linst checks

42207cf

Cleanup readme, fix makefile

ef1418a

stevieraykatz mentioned this pull request Sep 10, 2025

chore: add basenames disbursement15 #408

Merged

add records

d530f4c

amiecorso approved these changes Oct 2, 2025

View reviewed changes

eric-ships reviewed Oct 2, 2025

View reviewed changes

ilikesymmetry reviewed Oct 3, 2025

View reviewed changes

Get ready for ownership changeover #401

Are you sure you want to change the base?

Get ready for ownership changeover #401

Uh oh!

Conversation

stevieraykatz commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cb-heimdall commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟡 Heimdall Review Status

Uh oh!

github-actions bot commented Aug 15, 2025

❌ Upgrade Structure Validation Failed

Uh oh!

stevieraykatz commented Aug 15, 2025

❌ Upgrade Structure Validation Failed

Uh oh!

github-actions bot commented Aug 18, 2025

❌ Upgrade Structure Validation Failed

Uh oh!

github-actions bot commented Aug 19, 2025

❌ Upgrade Structure Validation Failed

Uh oh!

github-actions bot commented Aug 19, 2025

❌ Upgrade Structure Validation Failed

Uh oh!

github-actions bot commented Aug 19, 2025

❌ Upgrade Structure Validation Failed

Uh oh!

github-actions bot commented Sep 10, 2025

❌ Upgrade Structure Validation Failed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stevieraykatz Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stevieraykatz Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ilikesymmetry left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

stevieraykatz commented Aug 13, 2025 •

edited

Loading

cb-heimdall commented Aug 13, 2025 •

edited

Loading

stevieraykatz Oct 3, 2025 •

edited

Loading

stevieraykatz Oct 3, 2025 •

edited

Loading