[BA-3103] Utility for creating a link (deeplink, universal link, standard link) with a prolink #175
+487
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
|
feedback:
|
| * Create a link with an encoded prolink query parameter and additional query parameters | ||
| * | ||
| * @param prolink - Base64url-encoded prolink payload | ||
| * @param baseUrl - Base URL to use for the link, defaults to https://base.app/base-pay |
There was a problem hiding this comment.
'baseUrl' is proper but feels overloaded because we are 'base' - is there a closeby synonym we can use like 'prefixUrl'?
There was a problem hiding this comment.
maybe just url? its scoped to the function so likely need a prefix
There was a problem hiding this comment.
updated to url
| * @param prolink - Base64url-encoded prolink payload | ||
| * @param baseUrl - Base URL to use for the link, defaults to https://base.app/base-pay | ||
| * @param additionalQueryParams - Additional query parameters to add to the link | ||
| * @returns { link: string } - Object containing the full link |
There was a problem hiding this comment.
preference for returning the string directly - let me know if you have thoughts in the other direction
There was a problem hiding this comment.
thanks for the reminder here, updated to return a string
brendan-defi
changed the title
spencerstock
reviewed
Nov 3, 2025
| * @param prolink - Base64url-encoded prolink payload | ||
| * @param url - URL to use for the link, defaults to https://base.app/base-pay | ||
| * @param additionalQueryParams - Additional query parameters to add to the link | ||
| * @returns { link: string } - Object containing the full link |
There was a problem hiding this comment.
nit: update the docstring and usage example
There was a problem hiding this comment.
ugh I'm sorry for the oversight. thank you for catching 🙇
cb-jake
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
prolinkToUniversalLinkprolinkandenvironmentHow did you test your changes?
When a prolink is generated on playground...
...a corresponding "link with prolink" result is created (defaulted to base-app link).
We also demonstrate the ability to customize the link URL in a top-level "Link with Prolink" tab:
