Support directory symlinks during profile install#91
Closed
jantunes-te wants to merge 1 commit into
Closed
Conversation
Allow profile installation to copy symlinked directories recursively instead of failing through std::fs::copy. Track copied files under the target directory in the lockfile and preserve overwrite semantics for owned directory entries during forced reinstall. Add regression tests covering initial install and forced reinstall for symlinked directories.
Author
|
Closing per request: keeping changes local without PR/commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::fs::copyon a directory--forcereinstall when directory contents are already owned by the same profileRepro
skills/sample -> ../../skills/sample).codanna profile install <profile>.IO error: the source path is neither a regular file nor a symlink to a regular fileTests
cargo test --test profiles_tests symlinked_directory -- --nocapturecargo test --test profiles_tests test_install_profile_conflict_creates_sidecar -- --nocapture