Skip to content

feat: Implement Lua Support - #84

Merged
bartolli merged 5 commits into
bartolli:mainfrom
KyleKing:kyle/add-lua
Jan 30, 2026
Merged

feat: Implement Lua Support#84
bartolli merged 5 commits into
bartolli:mainfrom
KyleKing:kyle/add-lua

Conversation

@KyleKing

Copy link
Copy Markdown
Contributor

I think this is ready for at least a first-pass review!

It seems to be working and I'll keep testing it while I finish a package for nvim: https://github.com/KyleKing/codanna.nvim

@bartolli

Copy link
Copy Markdown
Owner

Thank you @KyleKing for the contribution, appreciate it! Please rebase on latest main (v0.9.12)

I've just merged a release with significant API changes that will likely affect your branch.

Key changes to be aware of:

  • JSON output now uses a unified Envelope format - breaking change for --json consumers
  • Removed dead code including the Tantivy resolution methods (resolve_import, build_resolution_context, resolve_import_path, etc.)
  • file_extensions() removed from LanguageBehavior trait - use LanguageDefinition::extensions() instead
  • New required trait method: format_path_as_module for language-specific path formatting
  • Added shared path utilities in src/parsing/paths.rs

When you have a moment, please rebase your branch on main. Let me know if you run into any conflicts or have questions.

@KyleKing

Copy link
Copy Markdown
Contributor Author

Thanks, I think I've made the appropriate updates, but let me know if this looks okay

@KyleKing

Copy link
Copy Markdown
Contributor Author

I realized there were a few more places where lua needed to be added, but I think it now might be ready for review?

@bartolli

Copy link
Copy Markdown
Owner

I realized there were a few more places where lua needed to be added, but I think it now might be ready for review?

Thank you! I'll review it tomorrow. If there's anything to fix, I'll take care of it.

@KyleKing
KyleKing marked this pull request as draft January 25, 2026 15:47
@KyleKing

Copy link
Copy Markdown
Contributor Author

There are a lot of changes and i realized I have copilot access for some reason, so I had it run a review and it had some valid findings. I'm doing some additional testing against larger lua code bases and will have a review-ready update by tomorrow!

@KyleKing

Copy link
Copy Markdown
Contributor Author

Seems to be working! I was missing the functionality to track relationships, but that now works and returned reasonable results on nvim's repo

@KyleKing
KyleKing marked this pull request as ready for review January 25, 2026 21:19
@bartolli

Copy link
Copy Markdown
Owner

I’ve been under the weather this past week and haven’t been able to review the PR yet. I’ll need a few more days to get back to you.. Thanks for the time and effort you’ve put into this.

@KyleKing

Copy link
Copy Markdown
Contributor Author

No worries and no rush, I hope you feel better!

@bartolli
bartolli merged commit 1260f62 into bartolli:main Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants