fix(test): handle Windows file URLs in marketplace resolution tests - #59
Merged
bartolli merged 1 commit intoOct 29, 2025
Conversation
Add path_to_file_url helper to properly format file:// URLs for cross-platform compatibility (Windows uses backslashes that need to be converted to forward slashes in URLs). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
✅ Quick checks success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes marketplace resolution tests to properly handle file:// URLs on Windows by converting backslashes to forward slashes.
Changes
path_to_file_url()helper function to convert file paths to proper file:// URLsinstall_supports_git_source_objecttest to use the helperupdate_external_plugin_detects_up_to_datetest to use the helperTechnical Details
Windows uses backslashes (
\) in file paths, which need to be converted to forward slashes (/) for file:// URLs. The helper ensures cross-platform compatibility by:file:///prefix (3 slashes) for both Unix and Windows absolute pathsTest Coverage
Related Issues
Resolves Windows-specific test failures in marketplace resolution tests