Be consistent with how the type is accessed

baopham · Aug 8, 2020 · b9217ae · b9217ae
1 parent c054ebb
commit b9217ae
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/src/ConditionAnalyzer/Analyzer.php b/src/ConditionAnalyzer/Analyzer.php
@@ -199,16 +199,11 @@ private function getIndex()
 
     private function hasValidQueryOperator($hash, $range = null)
     {
-        $hashCondition = $this->getCondition($hash);
-
-        $validQueryOp = ComparisonOperator::isValidQueryDynamoDbOperator($hashCondition['type'] ?? null);
+        $hashConditionType = $this->getCondition($hash)['type'] ?? null;
+        $validQueryOp = ComparisonOperator::isValidQueryDynamoDbOperator($hashConditionType);
 
         if ($validQueryOp && $range) {
             $rangeConditionType = $this->getCondition($range)['type'] ?? null;
-            if ($rangeConditionType === null) {
-                return false;
-            }
-
             $validQueryOp = ComparisonOperator::isValidQueryDynamoDbOperator(
                 $rangeConditionType,
                 true