Refactor ModelObserver

baopham · Sep 26, 2018 · 4c5b11b · 4c5b11b
1 parent 2269286
commit 4c5b11b
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/src/ModelObserver.php b/src/ModelObserver.php
@@ -32,21 +32,21 @@ public function __construct(DynamoDbClientInterface $dynamoDb)
         $this->attributeFilter = $dynamoDb->getAttributeFilter();
     }
 
-    protected function _save($model)
+    private function saveToDynamoDb($model)
     {
         $attrs = $model->attributesToArray();
-        // $this->attributeFilter->filter($attrs);
+
         try {
             $this->dynamoDbClient->putItem([
                 'TableName' => $model->getDynamoDbTableName(),
                 'Item' => $this->marshaler->marshalItem($attrs),
             ]);
         } catch (Exception $e) {
-            Log::info($e);
+            Log::error($e);
         }
     }
 
-    protected function _delete($model)
+    private function deleteFromDynamoDb($model)
     {
         $key = [$model->getKeyName() => $model->getKey()];
 
@@ -56,27 +56,27 @@ protected function _delete($model)
                 'Key' => $this->marshaler->marshalItem($key),
             ]);
         } catch (Exception $e) {
-            Log::info($e);
+            Log::error($e);
         }
     }
 
     public function created($model)
     {
-        $this->_save($model);
+        $this->saveToDynamoDb($model);
     }
 
     public function updated($model)
     {
-        $this->_save($model);
+        $this->saveToDynamoDb($model);
     }
 
     public function deleted($model)
     {
-        $this->_delete($model);
+        $this->deleteFromDynamoDb($model);
     }
 
     public function restored($model)
     {
-        $this->_save($model);
+        $this->saveToDynamoDb($model);
     }
 }