Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

## Description #1080

Closed
wants to merge 29 commits into from

Merge branch 'master' into updeps

9fa0856
Select commit
Loading
Failed to load commit list.
Closed

## Description #1080

Merge branch 'master' into updeps
9fa0856
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed Apr 25, 2024 in 1s

1/3 Fail(s): DESCRIPTION

Status: FAIL

    Here are some stats of the run:
    3 validations were ran.
    2 PASSED
    1 FAILED

Details

✔️ Validator: TITLE

  • ✔️ title must exclude '^([wip]|wip:)'
    Input : ## Description
    Settings : {"must_exclude":{"regex":"^(\\[wip\\]|wip:)","message":"WIP tag in PR title"}}

✔️ Validator: LABEL

  • ✔️ label must exclude 'wip'
    Input :
    Settings : {"must_exclude":{"regex":"wip","message":"WIP label on PR"}}

❌ Validator: DESCRIPTION

  • ✔️ The description is not empty
    Input : Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
    related issues, other PRs, or technical references.

Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass
    Settings : {"no_empty":{"enabled":true,"message":"Description matter and should not be empty. Provide detail with **what** was changed, **why** it was changed, and **how** it was changed."}}
  • (Remaining tasks in the description.)
    Input : Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
    related issues, other PRs, or technical references.

Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass
    Settings : {"and":[{"must_exclude":{"regex":"\\[ \\]","message":"Remaining tasks in the description."}},{"must_exclude":{"regex":"no\\|yes|fixes #X, partially #Y, mentioned in #Z","message":"Please fill out the PR template."}}]}