Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make network part of blockchain validator criteria #449

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Make network part of blockchain validator criteria #449

merged 9 commits into from
Mar 28, 2024

Conversation

vplasencia
Copy link
Member

@vplasencia vplasencia commented Mar 24, 2024 •
edited
Loading

Description

This PR:

  • Makes network a parameter for blockchain validators.

  • Adds more networks to the blockchain credential: polygon mumbai, optimism sepolia and arbitrum sepolia.

The url for the blockchain credential would be:

http://localhost:3001/credentials?group=<group-id>&member=<member-commitment>&provider=blockchain&redirect_uri=<redirect-url>

Related Issue

Closes #443

Does this introduce a breaking change?

  • Yes
  • No

@vplasencia
refactor: make network a parameter for blockchain validators
105a42b 
Now network is a required parameter for the blockchain validator criteria

BREAKING CHANGE: Now the network parameter for the blockchain validators is part of the credential
criteria

re #443
@vplasencia
feat: support several networks in the blockchain credential
2b08f33 
now the blockchain credential supports polygon mumbai, optimism sepolia and arbitrum sepolia

re #443
@vercel Vercel
Copy link

vercel bot commented Mar 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 10:28am

@vplasencia vplasencia marked this pull request as draft March 24, 2024 19:51
@vplasencia vplasencia requested a review from 0xjei March 24, 2024 22:21
@vplasencia vplasencia marked this pull request as ready for review March 25, 2024 09:53
@vplasencia vplasencia linked an issue Mar 25, 2024 that may be closed by this pull request
Make network a parameter for blockchain-based credentials #443
Closed
@vplasencia vplasencia marked this pull request as draft March 25, 2024 12:02
@vplasencia
refactor: move the blockchain credential supported networks to the ba…
a08d082 
…ndada utils package

Since the supported networks are attached to the infrastructure and not to the credential package,
they have been to the bandada utils package.

re #443
@vplasencia
refactor: rename blockchainCredentialNetworks -> blockchainCredential…
0c1128c 
…SupportedNetworks

blockchainCredentialNetworks was renamed blockchainCredentialSupportedNetworks for clarity.

re #443
@vplasencia vplasencia marked this pull request as ready for review March 25, 2024 13:36
0xjei
0xjei approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@0xjei 0xjei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome job ✨ looooks good and ready to merge!

@vplasencia
feat: support avalanche c chain in the blockchain credential
9e77800 
The blockchainCredentialSupportedNetworks variable type changed to make it easier to identify a
network and display its name.

re #451
@vplasencia
test: update test to support the new type of blockchainCredentialSupp…
fc7159d 
…ortedNetworks

re #451
@vplasencia
Merge pull request #453 from bandada-infra/feat/blockchain-credential…
ab73138 
…-avalanche-c-chain

Support Avalanche C-Chain Fuji in the blockchain credential
@vplasencia vplasencia merged commit 75539f8 into dev Mar 28, 2024
4 checks passed
@vplasencia vplasencia deleted the ref/blockchain-validators branch March 31, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xjei 0xjei 0xjei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make network a parameter for blockchain-based credentials
2 participants
@vplasencia @0xjei