Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(general-info-step.tsx): added check to disable continue when NaN #432

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

aguzmant103
Copy link
Collaborator

Description

Disables continue button when checking if NaN on new group creation

Related Issue

closes #414

Does this introduce a breaking change?

  • Yes
  • No

@aguzmant103 aguzmant103 requested a review from vplasencia March 7, 2024 22:33
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks ✨

@vplasencia vplasencia changed the base branch from main to dev March 8, 2024 10:03
@vplasencia vplasencia merged commit 7b72c6e into dev Mar 8, 2024
2 checks passed
@vplasencia vplasencia deleted the feat/preventNaN branch March 11, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent NaN from being sent as a correct value of Fingerprint duration
2 participants