Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed axios config example #420

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Removed axios config example #420

merged 3 commits into from
Mar 5, 2024

Conversation

Ayoseun
Copy link
Contributor

@Ayoseun Ayoseun commented Mar 4, 2024

Description

Related Issue

#320

Does this introduce a breaking change?

  • No

Ayoseun added 2 commits March 4, 2024 16:32
Updated the ApiSdk constructor documentation comment to provide clearer guidance on the config parameter, specifying it as an Axios request config. Included an example demonstrating how the config object can be structured for various request options such as HTTP method, URL, query parameters, request body data, and headers. This enhancement improves the readability and usability of the codebase, making it easier for developers to understand and utilize the ApiSdk class.
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks great. Thank you!

I just left one comment.

libs/api-sdk/src/apiSdk.ts Outdated Show resolved Hide resolved
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! ✨

@vplasencia vplasencia merged commit 8d2a80b into bandada-infra:main Mar 5, 2024
2 checks passed
Copy link

gitpoap-bot bot commented Mar 5, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Bandada Contributor:

GitPOAP: 2024 Bandada Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants