refactor: update optional parameters

bandada-infra · Feb 6, 2024 · 9ab8978 · 9ab8978
1 parent 6d38f55
commit 9ab8978
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/apps/api/src/app/credentials/credentials.controller.ts b/apps/api/src/app/credentials/credentials.controller.ts
@@ -19,8 +19,8 @@ export class CredentialsController {
         @Body() dto: AddMemberDto
     ): Promise<void | any> {
         return this.credentialsService.addMember(
-            dto.oAuthCode,
             dto.oAuthState,
+            dto.oAuthCode,
             dto.address,
             dto.network,
             dto.blockNumber

diff --git a/apps/api/src/app/credentials/dto/add-member.dto.ts b/apps/api/src/app/credentials/dto/add-member.dto.ts
@@ -1,12 +1,12 @@
 import { IsString, IsOptional } from "class-validator"
 
 export class AddMemberDto {
-    @IsOptional()
     @IsString()
-    readonly oAuthCode: string
+    readonly oAuthState: string
 
+    @IsOptional()
     @IsString()
-    readonly oAuthState: string
+    readonly oAuthCode: string
 
     @IsOptional()
     @IsString()

diff --git a/apps/dashboard/src/api/bandadaAPI.ts b/apps/dashboard/src/api/bandadaAPI.ts
@@ -248,9 +248,9 @@ export async function setOAuthState(
  */
 export async function addMemberByCredentials(
     oAuthState: string,
-    oAuthCode: string,
-    address: string,
-    network: string,
+    oAuthCode?: string,
+    address?: string,
+    network?: string,
     blockNumber?: string
 ): Promise<string | null> {
     try {