fix: prevent crash when new releases contain geo-blocked albums#287
Merged
bambanah merged 2 commits intobambanah:mainfrom Mar 26, 2026
Merged
Conversation
When Deezer's new releases feed contains geo-blocked tracks, getAlbumDetails() throws a GWAPIError. This unhandled rejection crashed the entire deemix process. Now each album is fetched individually with a .catch(), so unavailable albums are skipped with a warning instead of bringing down the server.
🦋 Changeset detectedLatest commit: 7b2a7b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Owner
|
Thanks for the PR! Can you please add a changeset ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem?
When Deezer's new releases feed contains albums that are geo-blocked in your region,
getAlbumDetails()throws aGWAPIError: Track unavailable on Deezer. This was an unhandled Promise rejection that crashed the entire deemix process.The crash shows up in logs like this:
After the crash, deemix restarts and the next
/api/newReleasescall crashes it again.What's the fix?
Each album is now fetched individually with a
.catch(), so geo-blocked albums are silently skipped (with aconsole.warn) instead of bringing down the whole server. The response just omits the unavailable albums.How was this tested?
Tested locally with a deemix Docker container (
ghcr.io/bambanah/deemix:latest). Before the fix, any call to/api/newReleasesfrom the Lidarr deemix plugin crashed the process. After patching the compileddist/newReleases.jsand restarting the container, deemix stayed up and the Lidarr indexer worked correctly.