Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fragments Returning null Value for non-null Types #2184

Merged

Conversation

DimuthuMadushan
Copy link
Contributor

Purpose

Fixes: #7689

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • No commons package changes (if there are any, please update the GraphQL version in GraphQL tools and Ballerina dev tools)
  • No compiler package changes (if there are any, please update the GraphQL version in Ballerina dev tools)

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.96%. Comparing base (49d4ca1) to head (e54e460).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
ballerina/response_formatter.bal 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2184      +/-   ##
============================================
+ Coverage     82.95%   82.96%   +0.01%     
  Complexity      824      824              
============================================
  Files           127      127              
  Lines          9866     9875       +9     
  Branches       2060     2063       +3     
============================================
+ Hits           8184     8193       +9     
  Misses         1336     1336              
  Partials        346      346              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ThisaruGuruge ThisaruGuruge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor comment.

@DimuthuMadushan DimuthuMadushan merged commit 22594e2 into ballerina-platform:master Mar 19, 2025
8 checks passed
@DimuthuMadushan DimuthuMadushan deleted the formatter-fix branch March 19, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fragments Return null Value for non-null Types
2 participants