Unified worker #996
Draft
Unified worker #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: minor Signed-off-by: Joseph Kogut <[email protected]>
Change-type: patch Signed-off-by: Joseph Kogut <[email protected]>
Remove catch block that unconditionally returns undefined, swallowing any exceptions. Instead, allow them to be raised, increasing visibility and debuggability. Change-type: patch Signed-off-by: Joseph Kogut <[email protected]>
Worker becomes BaseWorker, the interface for workers. Remove server code, instead allowing worker implementations to directly inherit from and override base worker functionality. Change-type: patch Signed-off-by: Joseph Kogut <[email protected]>
Previously, images used for testing were gzipped, and would be extracted to a temporary location before flashing and executing tests. This necessitated gzipping the image before using it, and introduced unnecessary complexity and runtime costs. Remove it in favor of a single input image path to an uncompressed image. Change-type: patch Signed-off-by: Joseph Kogut <[email protected]>
https://www.typescriptlang.org/tsconfig#lib Change-type: patch Signed-off-by: Joseph Kogut <[email protected]>
https://www.typescriptlang.org/tsconfig#esModuleInterop Change-type: patch Signed-off-by: Joseph Kogut <[email protected]>
Change-type: patch Signed-off-by: Joseph Kogut <[email protected]>
Change-type: patch Signed-off-by: Joseph Kogut <[email protected]>
klutchell
reviewed
May 17, 2023
klutchell
reviewed
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the QEMU worker into the core module, removing the IPC mechanism at the same time.
A CLI script becomes the entrypoint for testing.
This PR requires the unified-leviathan branch from meta-balena to run the unmanaged OS suite.