core: attempt to catch massive error dump when getting an errow hile … #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutchell
reviewed
Aug 23, 2024
| reject(error); | ||
| req.on('error', (error) => { | ||
| this.logger.log('Core side error when trying to send image to worker'); | ||
| reject(new Error('Error while sending image to worker')); |
There was a problem hiding this comment.
Are we losing any valuable information here? Like the error code or something that could help with debugging?
There was a problem hiding this comment.
The core dump usually doesn't give off any important information.
I would say if this is actually the source of the large core dump, then let's see if there any is any useful information that could be fetched from the error object?
There was a problem hiding this comment.
@rcooke-warwick can we still log error.message somewhere, assuming that's not where the dump is coming from? I don't like hiding all context from the error object.
rcooke-warwick
force-pushed
the
ryan/flash-error
branch
2 times, most recently
from
96cc445 to
920ddb2
Compare
rcooke-warwick
had a problem deploying
to
balena-cloud.com
GitHub Actions
Failure
rcooke-warwick
had a problem deploying
to
balena-cloud.com
GitHub Actions
Failure
rcooke-warwick
had a problem deploying
to
bm.balena-dev.com
GitHub Actions
Failure
rcooke-warwick
had a problem deploying
to
bm.balena-dev.com
GitHub Actions
Failure
…flashing There is a large dump of errors sometimes when there is a connection fault while flashing the DUT via /flash on the worker. Attempt to catch it with this change to avoid large, useless crashdump in the logs Change-type: patch Signed-off-by: Ryan Cooke <[email protected]>
rcooke-warwick
force-pushed
the
ryan/flash-error
branch
from
920ddb2 to
eae138e
Compare
rcooke-warwick
had a problem deploying
to
balena-cloud.com
GitHub Actions
Failure
rcooke-warwick
had a problem deploying
to
balena-cloud.com
GitHub Actions
Failure
rcooke-warwick
had a problem deploying
to
bm.balena-dev.com
GitHub Actions
Failure
rcooke-warwick
had a problem deploying
to
bm.balena-dev.com
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…flashing
There is a large dump of errors sometimes when there is a connection fault while flashing the DUT via /flash on the worker. Attempt to catch it with this change to avoid large, useless crashdump in the logs
Change-type: patch