respect arch param when sort=semver in [DockerVersion] badge #10905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
bug
chris48s
commented
Feb 24, 2025
| export { | ||
| sizeDataNoTagSemVerSort, | ||
| versionDataNoTagDateSort, | ||
| versionPagedDataNoTagDateSort, | ||
| versionDataNoTagSemVerSort, | ||
| versionDataWithTag, | ||
| versionDataWithVaryingArchitectures, | ||
| versionDataWithArchSpecificVersions, |
There was a problem hiding this comment.
Today in "naming things is hard"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #10904
This is a bit of a "remove spacebar heating" change
I think my reading here is that this change fundamentally brings the code into line with the documented behaviour, so we could consider it a non-breaking change.
That said, this probably is going to change the result of this badge for some projects in the wild which rely on the fact the semver variant ignores architectures (because it assumes projects follow the more normal pattern where you push multiple architectures to a single version tag).
As such, this is a bit of a debatable one. I can see that we could equally choose to not merge this to preserve backwards compatibility and document more clearly the existing behaviour.