remove logoWidth param
#10878
remove logoWidth param
#10878
Conversation
| @@ -4,6 +4,7 @@ const { normalizeColor, toSvgColor } = require('./color') | |||
| const badgeRenderers = require('./badge-renderers') | |||
| const { stripXmlWhitespace } = require('./xml') | |||
| const { DEFAULT_LOGO_HEIGHT } = require('./constants') | |||
| const { getIconSize } = require('./svg-helpers.js') | |||
There was a problem hiding this comment.
svg-helpers.js resides at /lib and not inside the lib of badge-maker /badge-maker/lib
😵
|
There are some projects that use the Should we use a new parameter to allow users to customize the icon size? |
Wouldn't this example still work as it uses the logo is a bit bigger but doesnt seem to change drastically. But i do get that this might break other badges using logos without |
|
The purpose of deleting it is to remove it.
If people are using it without, its probably a hangover from the popout style which was removed in 2019 or just inserting strange spacing. Either way, its time for this to go. |
Fixes #10285
notice - i moved the auto logo size logic into badge-maker as it makes sense here, my logic was that its related to badge render, let me know if that was the right move.