Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove extraneous migration information #3251

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

BethGriggs
Copy link
Collaborator

Hey, I just made a Pull Request!

I figure this information is no longer relevant as it is focused on the historic bulk migrations. And since this was added we've extended CONTRIBUTING.md.

✔️ Checklist

  • Added or updated documentation
  • All your commits have a Signed-off-by line in the message. (more info)

@BethGriggs BethGriggs requested a review from a team as a code owner March 14, 2025 23:22
@BethGriggs BethGriggs requested a review from 04kash March 14, 2025 23:22
Copy link
Member

@04kash 04kash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! I think we can also work on generalizing the migration script under repo-tools and eventually offer the community an automated option for migrating plugins as well.


### Migration process

The migration of plugins from the `backstage/backstage` monorepo to the `community-plugins` repository was automated under the `community-cli` tool.
Copy link
Contributor

@logonoff logonoff Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth to move this information to CONTRIBUTING.md, or to also remove the associated script?

Removing this information from the README appears to leave @backstage-community/cli migrate largely undocumented since CONTRIBUTING.md doesn't appear to mention the script

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the script is okay to be less documented for now as it's not ready or intended for general consumption in its current form (as @04kash mentioned). But, equally, I don't think we want to jump to removing the actual tooling/script while there are plans to improve it.

@04kash
Copy link
Member

04kash commented Mar 19, 2025

I have opened an issue to track improvements to the script: Issue #3271 and I think we can go ahead with merging this PR for now.

@04kash 04kash merged commit 18814be into backstage:main Mar 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants