-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(copilot): Adds engagement and seat analysis metrics #3241
base: main
Are you sure you want to change the base?
Conversation
Changed Packages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @henrikedegrd, left a few comments
workspaces/copilot/plugins/copilot-backend/migrations/202503111030_add_seat_analysys.js
Outdated
Show resolved
Hide resolved
Fixed them, and also fixed a bug where I fetched the wrong datapoint for some metrics. |
Should be good to merge after conflicts are resolved |
Changes the backend to use octokit in order to have pagination Signed-off-by: Henrik Edegård <[email protected]>
Signed-off-by: Henrik Edegård <[email protected]>
Signed-off-by: Henrik Edegård <[email protected]>
Signed-off-by: Henrik Edegård <[email protected]>
Signed-off-by: Henrik Edegård <[email protected]>
Signed-off-by: Henrik Edegård <[email protected]>
Signed-off-by: Henrik Edegård <[email protected]>
1aec1a2
to
75704af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks @henrikedegrd
Hey, I just made a Pull Request!
Adds metrics for engagement and seat analysis.
It adds a few new metrics:
The new metrics are presented with the value from the last day of the selected period range, since an average of the above does not make sense.
It also show some new metrics from the previous change to the new metrics API:
Average metrics of the above are calculated excluding weekends, since that can make the average a bit missleading.
Backend also changed to use octokit to fetch data from Github.
Also found that when using PostgreSQL as database, the unique index using null are not working as expected. So the new metrics use empty string instead. This will have to be addressed for the other metrics also. Will do that in a separate PR.
✔️ Checklist
Signed-off-by
line in the message. (more info)