plugin(jenkins-backend): Add extension point #3000
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an extension point to the `jenkins-backend` plugin so a custom JenkinsInforProvider can be used. Fixes backstage#2926 Signed-off-by: Luiz Carvalho <[email protected]>
2 tasks
Changed Packages
|
|
Yes it looks good. Thanks for the effort |
|
Anything else that needs to be done before this change is reviewed and, eventually, merged? |
|
@04kash @BethGriggs another Jenkins PR |
04kash
requested changes
Mar 14, 2025
There was a problem hiding this comment.
Thanks @lcarva! The docs would need to be updated on how to provide a custom JenkinsInfoProvider using this new extension point as well. You can take a look at the keycloak docs and the badges docs for examples.
| } | ||
|
|
||
| /** | ||
| * Extension point that allows a different JenkinsInfoProvider to be used. |
There was a problem hiding this comment.
Suggested change
| * Extension point that allows a different JenkinsInfoProvider to be used. | |
| * Extension point that allows a custom JenkinsInfoProvider to be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Add an extension point to the
jenkins-backendplugin so a custom JenkinsInforProvider can be used.✔️ Checklist
Signed-off-byline in the message. (more info)