Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/rbac: fixing loaders on role list table #2922

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

bugfix/rbac: fixing loaders on role list table #2922

wants to merge 7 commits into from

Conversation

its-mitesh-kumar
Copy link
Contributor

@its-mitesh-kumar its-mitesh-kumar commented Feb 17, 2025 •
edited
Loading

Fixing https://issues.redhat.com/browse/RHIDP-6029
I was able to reproduce the issue by throttling the network to 3G. With the fix, the issue will be resolved.
Upstream issue : #2802

@its-mitesh-kumar
Copy link
Contributor Author

cc @divyanshiGupta

@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Feb 17, 2025 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-rbac workspaces/rbac/plugins/rbac patch v1.38.1

@divyanshiGupta divyanshiGupta mentioned this pull request Feb 18, 2025
Open
2 tasks
@divyanshiGupta
Copy link
Contributor

Please fix prettier issues in useRoles.ts file.

divyanshiGupta
divyanshiGupta suggested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@divyanshiGupta divyanshiGupta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@its-mitesh-kumar Table is getting re-rendered on each fetch. PTAL.

PR

Screen.Recording.2025-02-20.at.7.50.09.PM.mov

Main

Screen.Recording.2025-02-20.at.7.55.10.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyanshiGupta divyanshiGupta divyanshiGupta requested changes

@AndrienkoAleksandr AndrienkoAleksandr Awaiting requested review from AndrienkoAleksandr AndrienkoAleksandr is a code owner

@christoph-jerolimov christoph-jerolimov Awaiting requested review from christoph-jerolimov christoph-jerolimov is a code owner

@PatAKnight PatAKnight Awaiting requested review from PatAKnight PatAKnight is a code owner

@awanlin awanlin Awaiting requested review from awanlin awanlin is a code owner automatically assigned from backstage/community-plugins-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
workspace/rbac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@its-mitesh-kumar @divyanshiGupta @BethGriggs