Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate announcements-common from procore-oss #2154

Merged
merged 21 commits into from
Dec 24, 2024
Merged

Migrate announcements-common from procore-oss #2154

merged 21 commits into from
Dec 24, 2024

Conversation

kurtaking
Copy link
Member

Hey, I just made a Pull Request!

This PR includes announcements-common from procore-oss. Tracking the migrate in procore-oss/backstage-plugin-announcements#373.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@kurtaking kurtaking changed the title Announcements common Migrate announcements-common from procore-oss Dec 7, 2024
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-announcements-common workspaces/announcements/plugins/announcements-common none v0.1.0
@backstage-community/plugin-search-backend-module-announcements workspaces/announcements/plugins/search-backend-module-announcements none v0.1.0

@kurtaking kurtaking force-pushed the announcements-common branch from 6d3db49 to c53bdfe Compare December 7, 2024 03:29
@kurtaking kurtaking mentioned this pull request Dec 7, 2024
Closed
6 tasks
@kurtaking
Copy link
Member Author

#2148 should be reviewed and merged first.

@kurtaking
Copy link
Member Author

This PR is still relevant. I will get it updated and ready for review once #2148 is merged.

@backstage-goalie
Copy link
Contributor

Thanks for the contribution!
All commits need to be DCO signed before they are reviewed. Please refer to the the DCO section in CONTRIBUTING.md or the DCO status for more info.

awanlin
awanlin requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @kurtaking, just left one comment.

workspaces/announcements/plugins/announcements-common/src/setupTests.ts Outdated Show resolved Hide resolved
@kurtaking kurtaking marked this pull request as ready for review December 20, 2024 18:32
@kurtaking kurtaking requested a review from a team as a code owner December 20, 2024 18:32
awanlin
awanlin approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another PR down, thanks again @kurtaking 🚀

@awanlin awanlin enabled auto-merge (squash) December 24, 2024 00:02
@awanlin awanlin merged commit c400851 into backstage:main Dec 24, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awanlin awanlin awanlin approved these changes

@nickboldt nickboldt Awaiting requested review from nickboldt nickboldt is a code owner automatically assigned from backstage/community-plugins-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurtaking @awanlin