Add TechInsightCheck metadata #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
|
Thanks for the contribution! |
Signed-off-by: Maica Ballangan <[email protected]>
hballangan-mdsol
force-pushed
the
feature/techinsights-add-metadata
branch
from
e3cb8a8 to
5d1618e
Compare
Signed-off-by: Maica Ballangan <[email protected]>
|
Hi @Xantier can I get a review for this PR? |
Xantier
reviewed
Dec 16, 2024
| --- | ||
| '@backstage-community/plugin-tech-insights-backend-module-jsonfc': patch | ||
| '@backstage-community/plugin-tech-insights-common': patch | ||
| '@backstage-community/plugin-tech-insights-node': patch |
There was a problem hiding this comment.
node package already follows semver best practices and is above 1.x so let's follow the conventions and make this a minor change.
There was a problem hiding this comment.
Thanks @Xantier, updated description to minor in new commit
Signed-off-by: Maica Ballangan <[email protected]>
Xantier
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TechInsightCheck metadata
Adds a general techinsights check metadata that will be copied to the Check Response both on failure and success. This enables users to use existing JsonRulesEngineFactChecker with additional metadata that can be displayed in the UI
✔️ Checklist
Signed-off-byline in the message. (more info)