fix!: Use builtin probe endpoints #216
Conversation
nikolaik
force-pushed
the
nikolaik/healthchecks-v1.29
branch
from
5acd31b
to
9c93fa6
Compare
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
Hi @nikolaik would you be able to update the branch with the |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
nikolaik
force-pushed
the
nikolaik/healthchecks-v1.29
branch
from
9c93fa6
to
61e3539
Compare
Rebased now <3 |
|
@nikolaik Seems to be some test failures in the pipeline, are you able to take a look? |
nikolaik
force-pushed
the
nikolaik/healthchecks-v1.29
branch
from
61e3539
to
144247f
Compare
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
nikolaik
force-pushed
the
nikolaik/healthchecks-v1.29
branch
from
ced9d20
to
1c75a54
Compare
@ChrisJBurns Sorry for the delay! Found the issue with the failing tests |
There was a problem hiding this comment.
Hi @nikolaik!
I've noticed that the PR isn't actually specifying the new values as default:
nikolaik
force-pushed
the
nikolaik/healthchecks-v1.29
branch
from
1c75a54
to
156514c
Compare
Fixed now! But hitting another issue with the |
nikolaik
force-pushed
the
nikolaik/healthchecks-v1.29
branch
from
156514c
to
6d92b9f
Compare
|
@vinzscam This should be good for a re-review |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
lgtm |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
nikolaik
force-pushed
the
nikolaik/healthchecks-v1.29
branch
from
6d92b9f
to
7e92b05
Compare
These are `/.backstage/health/v1/readiness` and `/.backstage/health/v1/liveness` and were added in v1.29 Ref: https://backstage.io/docs/releases/v1.29.0#backend-health-service Signed-off-by: Nikolai Røed Kristiansen <[email protected]>
Techdocs needs to be configured in app config. Point our image-digest test to the v1.31.0 sha Signed-off-by: Nikolai Røed Kristiansen <[email protected]>
nikolaik
force-pushed
the
nikolaik/healthchecks-v1.29
branch
from
7e92b05
to
9e25207
Compare
Description of the change
This starts using the built in probe endpoints.
These are
/.backstage/health/v1/readinessand/.backstage/health/v1/livenessand were added in v1.29Ref: https://backstage.io/docs/releases/v1.29.0#backend-health-service
I made this a breaking change, since these are new defaults
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.