Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add namespace to configmap = .Release.Namespace; bump chart version to 1.9.3; update/regen docs #178

Merged
merged 1 commit into from
May 9, 2024

Conversation

nickboldt
Copy link
Contributor

@nickboldt nickboldt commented Apr 20, 2024

fix: add namespace to configmap = .Release.Namespace; bump chart version to 1.9.3; update/regen docs

Signed-off-by: Nick Boldt [email protected]

Based on proposed changes in #176 from @IronMage but with DCO fixed and more complete pre-commit hooks applied.

Run standard RH pre-commit checks........................................Passed
Helm Docs................................................................Passed
jsonschema-dereference...................................................Passed

Ref: https://issues.redhat.com/browse/RHIDP-2170

@nickboldt nickboldt requested a review from a team as a code owner April 20, 2024 12:21
@nickboldt nickboldt changed the title update chart version fix: add namespace to configmap = .Release.Namespace; bump chart version to 1.9.3; update/regen docs Apr 20, 2024
@nickboldt nickboldt mentioned this pull request Apr 20, 2024
4 tasks
@nickboldt
Copy link
Contributor Author

Hey @ChrisJBurns can you explain why the lint test failed here? was it something in my regenerated doc?

Copy link

github-actions bot commented May 2, 2024

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@ChrisJBurns
Copy link
Contributor

@nickboldt This is because by default auth is enabled in newer versions of Backstage now. I have raised #186 to resolve this. This should then allow your PR to pass testing.

…ion to 1.9.3; update/regen docs

Signed-off-by: Nick Boldt <[email protected]>
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @nickboldt 🙏

@vinzscam vinzscam merged commit 0bf76cc into backstage:main May 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants