Repository navigation
Fix CodeQL workflow and endpoint alerts - #1
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The endpoint-matching change is precise, security-improving, and is backed by targeted regression tests, and the CI permissions change is a safe least-privilege adjustment.
Pull request overview
This PR hardens endpoint detection for Backblaze B2 S3-compatible URLs to avoid substring-based false positives and aligns the CI workflow with least-privilege GitHub Actions token permissions (addressing CodeQL/workflow security alerts).
Changes:
- Restricts Backblaze endpoint detection to the exact
backblazeb2.comhost or valid*.backblazeb2.comsubdomains (case-insensitive, tolerating a trailing dot). - Adds regression tests to cover domain-boundary and casing/trailing-dot edge cases.
- Sets explicit read-only
GITHUB_TOKENpermissions (contents: read) for the CI workflow.
File summaries
| File | Description |
|---|---|
src/hf_cache_sync/storage.py |
Tightens _is_backblaze_endpoint host matching to prevent substring-based misclassification. |
tests/test_storage.py |
Adds regression coverage for exact-host/subdomain matching and negative boundary cases. |
.github/workflows/ci.yml |
Adds explicit minimal workflow token permissions (contents: read). |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Linked Dependabot alerts:
Tests run:
Follow-up notes: