Skip to content

fix: limit test workflow permissions - #1

Merged
goanpeca merged 2 commits into
mainfrom
fix/actions-permissions-2026-09-02
Sep 2, 2026
Merged

goanpeca merged 2 commits into
mainfrom
fix/actions-permissions-2026-09-02

Conversation

@goanpeca

@goanpeca goanpeca commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add explicit workflow-level GITHUB_TOKEN permissions to .github/workflows/test.yml.
  • Restrict the test workflow token to contents: read, which is sufficient for checkout and test execution.

Linked alerts

Tests run

  • /Users/gpenacastellanos/miniforge3/condabin/conda run -n comfyui-cloud-storage-actions-permissions python -m pytest tests/ -v

Follow-up notes

  • No follow-up needed.

Copilot AI lite review requested due to automatic review settings September 2, 2026 21:22
@goanpeca goanpeca self-assigned this Sep 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The workflow enables actions/setup-python pip caching, which typically requires actions: write, so the new read-only token scope may break or disable caching.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR tightens the GITHUB_TOKEN permissions in the test workflow by adding an explicit workflow-level permissions block.

Changes:

  • Add workflow-level permissions configuration to .github/workflows/test.yml
  • Restrict contents permission to read for the workflow token
File summaries
File Description
.github/workflows/test.yml Adds explicit GITHUB_TOKEN permissions to reduce token scope during CI tests.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/test.yml
@goanpeca
goanpeca merged commit 89eb2f6 into main Sep 2, 2026
7 checks passed
@goanpeca
goanpeca deleted the fix/actions-permissions-2026-09-02 branch September 2, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants