Repository navigation
fix: limit test workflow permissions - #1
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The workflow enables actions/setup-python pip caching, which typically requires actions: write, so the new read-only token scope may break or disable caching.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR tightens the GITHUB_TOKEN permissions in the test workflow by adding an explicit workflow-level permissions block.
Changes:
- Add workflow-level
permissionsconfiguration to.github/workflows/test.yml - Restrict
contentspermission toreadfor the workflow token
File summaries
| File | Description |
|---|---|
| .github/workflows/test.yml | Adds explicit GITHUB_TOKEN permissions to reduce token scope during CI tests. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GITHUB_TOKENpermissions to.github/workflows/test.yml.contents: read, which is sufficient for checkout and test execution.Linked alerts
Tests run
/Users/gpenacastellanos/miniforge3/condabin/conda run -n comfyui-cloud-storage-actions-permissions python -m pytest tests/ -vFollow-up notes