impl: multisig btc staker#225
Conversation
|
hey @Lazar955 , can u publish this commit(7989574) in the babylon repository to the docker hub? e2e test in the CI is failing because there are no such docker image on the hub. cc. @RafilxTenfen |
|
|
also @canu0205 feel free to tag our devops in the devops channel on slack when you need images built |
|
thanks @Lazar955 ! but I think I'm not in the devops slack channel and don't have permission to mention a devops. |
I have asked @maiquanghiep 🙌 |
| // StakerKeysConfig holds private key material for the staker-controlled taproot | ||
| // multisig branch. These keys are loaded directly into stakerd (testing | ||
| // scenario) and are independent of the wallet RPC config. | ||
| type StakerKeysConfig struct { |
There was a problem hiding this comment.
Lets specify in the name that this is for Multisig, maybe StakerMultisigConfig
| - In `stakerd.conf`, add a `[stakerkeys]` section with a comma-separated list of WIFs and a quorum: | ||
| ```ini | ||
| [stakerkeys] | ||
| StakerKeyWIFs = wif1,wif2,wif3 |
There was a problem hiding this comment.
could you add an example of the real keys
| ## Configure multisig staker keys | ||
| - In `stakerd.conf`, add a `[stakerkeys]` section with a comma-separated list of WIFs and a quorum: | ||
| ```ini | ||
| [stakerkeys] |
There was a problem hiding this comment.
| [stakerkeys] | |
| [multisigstakerkeys] |
There was a problem hiding this comment.
will make it stakermultisigconfig to be asymmetrical with stakerconfig
Lazar955
left a comment
Lazar955
left a comment
There was a problem hiding this comment.
Looks good! Nice work, let's merge so we can see the e2e working
| } | ||
|
|
||
| // in case of multisig btc stake expansion, it populates DelegationData and adds to MsgBtcStakeExpand | ||
| if dg.MultisigInfo != nil { |
There was a problem hiding this comment.
nit: but not sure if we can reduce duplication of this and at lines 570 of this file. Long nested ifs and building of the MultisigInfo, maybe a fcn populateMultisigInfo
|
|
||
| // NewImageConfig returns ImageConfig needed for running e2e test. | ||
| func NewImageConfig(t *testing.T) ImageConfig { | ||
| // TODO: Temporary fixed babylond version with snapshot tag |
There was a problem hiding this comment.
@RafilxTenfen @Lazar955 FYI. I've dealt with this TODO in this commit 5fb33ad.
now it supports babylond with snapshot tag on the docker hub is okay for btc-staker to run its own e2e test suites.
3 participants
Description
Closes: #208
Note: e2e tests currently failed because there are no images available on the docker hub for the given multisig supported babylon commit (7989574)
How to test
Will add e2e test in the other PR. you can test this with
babylon-deploymentchris/multisig branch here (babylonlabs-io/babylon-deployment#52).after pulling chris/multisig branch of babylon-deployment, run btcstaking-demo.sh by this command: