handling for spec/loose default changes for template literals and class properties #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahlemen
commented
Mar 3, 2018
| } else { | ||
| plugins.splice(i, 1); | ||
| i--; | ||
| } | ||
| } | ||
| } else { | ||
| if (plugin.indexOf('babel-plugin') !== 0 && plugin[0].indexOf('@babel/') !== 0) { |
There was a problem hiding this comment.
plugin[0].indexOf looked like a bug -- was preventing @babel/ prefixes from being recognized correctly
There was a problem hiding this comment.
submitting this as a separate PR with updated tests in #48
|
submitted said refactor in #50, will need to rebase this PR on that if it gets merged |
|
closing this for now, have some ideas for a new approach i want to play with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #10
attempts to transform options for
@babel/plugin-transform-template-literalsand@babel/plugin-proposal-class-properties:loose: truespec: true, removesspecflag and does not addloosecurrently, this logs to the console in any instance where these plugins were not explicitly included in config
only handles
specfor old template literals transform -- should it do anything with the oldlooseflag as well?after working in this file a bit, i've got some ideas for refactors, but i'll do that in a separate PR if i find the time