Bump up ibc from v8 to v10 by zsystm · Pull Request #3 · b-harvest/evm

zsystm · 2025-03-26T01:06:27Z

Description

Bumped IBC from v8 to v10.
Implemented v2 middleware and added basic IBC v2 test cases to verify it works.
- Note: This PR does not cover all test scenarios: Full E2E tests with dockerized evmd will be added in a separate PR.
Disabled feemarket base fee param for ExampleChain.
- Without this, we cannot use ibctesting package's code because we should set fee higher than base fee.
Removed unused IBC testing code.
- These were not used and can be replaced by components from the ibctesting package.

Notes

This PR is minimal and focuses on verifying that IBC v10 integration works as expected.
Tests for cases like receiving coins registered as erc20 token pair will be covered in future PRs.

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

tackled an existing issue or discussed with a team member
left instructions on how to review the changes
targeted the main branch

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

added a relevant changelog entry to the Unreleased section in CHANGELOG.md
confirmed all author checklist items have been addressed
confirmed that this PR does not change production code
reviewed content
tested instructions (if applicable)
confirmed all CI checks have passed

…s#24)

…os#37)

)

…ns (target main) (cosmos#52)

…cosmos#53)

…r minor clean up (cosmos#54)

…lt ERC-20 params and use it for example chain (cosmos#57)

Extended reference in license for clear attribution

* deps bump * remove local example_chain * bump ibc-go * bump cosmos-sdk * keep evm local replacement

* update readme * small language change

* switch to cosmos-sdk branched releases * example chain sdk migrate * migrate from evmos geth to cosmos geth * go mod tidy * go mod tidy

* fix vuln and vulncheck * patch glog vuln * glog upgrade * fix vulncheck * try new ci worfklow * upgrade go to 1.23 * make vulncheck nightly (shouldn't block PR) * test changelog (unfinished) * remove linting changelog * remove pat * run make format * remove semgrep * remove autoformat CI should not be modifying our code. Gofumpt is included in the lint, and we only have a single python script, so having an entire CI for linting Python is not worth it imo * remove legacy evmos license checker * golangci 1.23 * md fixes * more md fixes --------- Co-authored-by: vladjdk <16737210+vladjdk@users.noreply.github.com>

x/erc20/ibc_middleware_v2.go

* fix: cast send --legacy support * changelog --------- Co-authored-by: Eric Warehime <eric.warehime@gmail.com>

* Remove example_chain, move to evmd * Update changelog * Replace activators * Remove Makefile * Fix solidity tests

- bumped up ibc-go from v8 to v10 - removed unused ibc test codes because bumping unused testing codes are wasting time. we should use ibc testing package instead.

added ibc v1 test cases to make sure ExampleChain works with ibc v1. disabled basefee param as default for ExampleChain to make test easier.

- added ibc v2 components - copied basic v2 test cases from ibc-go v10 to make sure v2 components of ExampleChain works well.

* feat: add receiptsRoot to block (WIP) * fix: nil pointer in receipt when empty logs * feat(evm): add receiptsRoot state * test: add receiptsRoot test case * test(evm): add TestGetReceiptsRoot * test: add GetReceiptsRoot testcase * refactor(x/evm): modify getter/setter of receipts * fix: runtime error of example_chain * feat(rpc): add receiptsRoot into eth block.header * test: add testcase for getting receipt from transient store * feat: change encode/decode method for evm receipt * feat: modify key/value of receipt storage * chore: remove unnecessary test setup method call * chore: remove outdated file * fix: type error * fix(rpc): fix wrong assignment of receiptHash * fix(rpc): fix wrong assignment of receiptHash * chore(x/evm): modify comments and return type of receipts crud methods * chore(x.evm): modify receipts getther method

fedekunze and others added 30 commits January 6, 2023 10:51

Initial commit

7136beb

Update README.md

ae51a87

imp(ci): Add CI workflows, configurations, Makefile, License, etc. (#12)

c1bd781

feat(eip-712): Add EIP-712 package. (#13)

03c2ec3

imp(proto): Add Protobufs and adjust scripts (#14)

8cd0f94

imp(all): Add general types and utils (#15)

c1e757e

imp(types): Add required wallet types for integration (cosmos#19)

d5911ba

imp(types): Add crypto and encoding packages (cosmos#20)

e8beeb0

imp(rpc): Add RPC and indexer types (cosmos#21)

21c4148

imp(rpc): Add server implementation (cosmos#22)

c91bd10

imp(cli): Add client, cmd and version packages (cosmos#23)

8fe5a8b

imp(contracts): Add contracts directory and compilation script (cosmo…

0ce0abe

…s#24)

imp(ci): Disable dependabot temporarily (cosmos#35)

775d87b

feat(all): Add example chain implementation (cosmos#30)

6c1b1e4

imp(docs): Add readme (cosmos#38)

7f3d35a

imp(all): Add EVM, ERC-20, feemarket and precompiles from Evmos (cosm…

6780dc2

…os#37)

imp(tests): Add Solidity and Ledger tests (cosmos#41)

30aa9ff

imp(all): Update with latest Evmos main changes (cosmos#43)

b50f09c

imp(all): Move latest changes from Evmos main (incl. SDK v50) (cosmos#48

28f7eb5

)

imp(ante): Refactor ante handlers to be easier to use in partner chai…

16cd6fc

…ns (target main) (cosmos#52)

improvements(cli): Enable specifying default key type for adding keys (…

525afb7

…cosmos#53)

improvements(cli): Align debug CLI commands with Cosmos SDK plus othe…

1e22d61

…r minor clean up (cosmos#54)

imp(cli): Add missing list key types subcommand (cosmos#55)

225960e

imp(all): Bump to latest state on Evmos main (b72a32d76) (cosmos#60)

9fd2afe

test(evm): Add tests for bank wrapper (cosmos#65)

9309a19

test(evm): Add tests for feemarket wrapper (cosmos#66)

ee156f0

imp(erc20): Add reference to EIP-7528 (native asset address) to defau…

3997b84

…lt ERC-20 params and use it for example chain (cosmos#57)

imp(all): Bump to latest state on Evmos main (0402a01c) (cosmos#69)

396f93e

Update to Apache 2.0 License (cosmos#77)

bb2a877

gm evm

40bc412

qx-nico and others added 11 commits March 18, 2025 09:41

evmOS link

6b4b4cd

License - attribution

3c734a4

Extended reference in license for clear attribution

fix example chain

85bbdba

Merge remote-tracking branch 'origin/main'

5992681

fix solidity tests (#4)

bbeeb5f

fix: deps bump (#3)

8d31427

* deps bump * remove local example_chain * bump ibc-go * bump cosmos-sdk * keep evm local replacement

set ics gaia as codeowner (#7)

c3d8710

Update readme file (#13)

bc23253

* update readme * small language change

wip: chore: migrate forks (#9)

6a99973

* switch to cosmos-sdk branched releases * example chain sdk migrate * migrate from evmos geth to cosmos geth * go mod tidy * go mod tidy

Copy issue format from gaia (#12)

e8ae510

github-actions bot added tests precompile contracts labels Mar 26, 2025

github-advanced-security bot found potential problems Mar 26, 2025

View reviewed changes

vladjdk and others added 3 commits March 26, 2025 09:12

chore: fix lints and finalize ci to pass (#15)

08eb3b7

fix: cast send --legacy support (cosmos#27)

2305dc7

* fix: cast send --legacy support * changelog --------- Co-authored-by: Eric Warehime <eric.warehime@gmail.com>

feat: Remove example_chain, move to evmd (cosmos#31)

59c573a

* Remove example_chain, move to evmd * Update changelog * Replace activators * Remove Makefile * Fix solidity tests

zsystm changed the title ~~Bump up ibc from v8 to v10 & Setup e2e test env~~ Bump up ibc from v8 to v10 Mar 29, 2025

zsystm self-assigned this Mar 30, 2025

zsystm requested a review from dongsam March 31, 2025 01:02

zsystm added 3 commits March 31, 2025 13:38

bump up ibc-go from v8 to v10

43b8843

- bumped up ibc-go from v8 to v10 - removed unused ibc test codes because bumping unused testing codes are wasting time. we should use ibc testing package instead.

add ibc v1 transfer test

00f33e6

added ibc v1 test cases to make sure ExampleChain works with ibc v1. disabled basefee param as default for ExampleChain to make test easier.

add ibc v2 components (module, middleware)

748569a

- added ibc v2 components - copied basic v2 test cases from ibc-go v10 to make sure v2 components of ExampleChain works well.

zsystm closed this Mar 31, 2025

zsystm force-pushed the tests/ibc-e2e branch from 1c49248 to 748569a Compare March 31, 2025 05:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump up ibc from v8 to v10#3

Bump up ibc from v8 to v10#3
zsystm wants to merge 47 commits intomainfrom
tests/ibc-e2e

zsystm commented Mar 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

zsystm commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Author Checklist

Reviewers Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

zsystm commented Mar 26, 2025 •

edited

Loading