Add Color Grading effect with customizable properties #1442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuto-trd
force-pushed
the
feat/color-grading-effect
branch
from
39e5f12 to
622eb21
Compare
…ure, contrast, saturation, and more
…es for enhanced precision
…elated components
… improved style selectors
…duce GradingColorComponentsEditor
…hickness, gain, and grid visibility
…ys and improving cancellation handling
…nt and improve property registration
…n histogram and scope controls
…optimizing label positioning
…odes for enhanced visualization
… and updating related methods
…ntroduce GradingWheel control
…rading functionality
… upon closing the tab.
…urve manipulation
yuto-trd
force-pushed
the
feat/color-grading-effect
branch
from
7b9b7ea to
8b3a34b
Compare
…ng properties management
…oved disposal and JSON handling
…istence Refactor CurvesTabViewModel to subscribe directly to Effect changes instead of SelectedObject, add JSON serialization for selected group/channel/effect, and handle effect detachment properly. Add ColorCurves_Missing localization string and display missing effect message in CurvesTab UI.
Removed unused code for parsing the third color component and simplified the extraction of the blue component.
… on selection state
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a comprehensive Color Grading system with customizable color correction tools, color scopes for video analysis, and curve-based color adjustments. The implementation adds professional-grade color manipulation capabilities similar to those found in high-end video editing software.
Key Changes:
- Added three color scope visualizations (Waveform, Histogram, Vectorscope) for analyzing color distribution and luminance
- Implemented ColorGrading effect with controls for exposure, contrast, saturation, temperature/tint, and lift/gamma/gain adjustments
- Introduced Curves effect supporting RGB curves and HSL-based color adjustments with Bezier curve interpolation
Reviewed changes
Copilot reviewed 63 out of 64 changed files in this pull request and generated 31 comments.
Show a summary per file
| File | Description |
|---|---|
WaveformControl.cs |
Implements waveform scope with Luma, RGB Overlay, and RGB Parade modes |
HistogramControl.cs |
Provides RGB histogram visualization in overlay and parade modes |
VectorscopeControl.cs |
Displays color chrominance in YCbCr color space |
ScopeControlBase.cs |
Base class for scope controls with async rendering and double buffering |
ColorGrading.cs |
Filter effect implementing color grading with SKSL shader |
Curves.cs |
Filter effect for curve-based color adjustments with multiple curve types |
GradingColor.cs |
Data structure for color grading operations supporting negative RGB values |
CurveMap.cs |
Represents curve data with Bezier interpolation support |
GradingColorPicker.cs |
UI control for selecting grading colors with HSV/RGB modes |
ColorGradingWheel.cs |
Wheel-based color picker for intuitive color adjustments |
CurveVisualizationRenderer.cs |
Renders histogram visualizations for curve editors |
*TabViewModel.cs |
View models for integrating features into tool tabs |
*Extension.cs |
Service registrations for new features |
Files not reviewed (1)
- src/Beutl.Language/Strings.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…radingColorPicker and CurveEditor
Contributor
|
The following TODO comments were found: |
Contributor
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a Color Grading effect with customizable properties such as exposure, contrast, and saturation. Enhance functionality with a Color Wheel editor and picker, and improve the underlying shader and data structures for better precision and performance.
Breaking changes
None.
Fixed issues
None.