Deprecate CreateEffectNode and replace with CreateNode for audio effects #1434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
No TODO comments were found. |
Contributor
Minimum allowed line rate is |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the audio effects architecture by deprecating the CreateEffectNode method and processor-based pattern in favor of a new node-based approach using CreateNode. The change replaces the DelayEffect processor implementation with a dedicated DelayNode, streamlining the audio processing graph architecture.
- Removes the processor abstraction layer (
IAudioEffectProcessor,AudioEffectProcessorGroup,EffectNode) in favor of direct node creation - Implements
DelayNodeas a standalone audio node with improved memory efficiency and animation support - Updates audio effect properties to use
CreateAnimatablefor proper animation support
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Beutl.Engine/Audio/Sound.cs | Updates effect application to use new CreateNode pattern instead of deprecated CreateEffectNode |
| src/Beutl.Engine/Audio/Graph/Nodes/EffectNode.cs | Removes generic effect node wrapper, replaced by effect-specific nodes |
| src/Beutl.Engine/Audio/Graph/Nodes/DelayNode.cs | Adds dedicated delay node with static/animated processing modes and improved memory management |
| src/Beutl.Engine/Audio/Graph/AudioContext.cs | Removes deprecated CreateEffectNode method from context |
| src/Beutl.Engine/Audio/Effects/IAudioEffectProcessor.cs | Removes processor interface, replaced by node-based architecture |
| src/Beutl.Engine/Audio/Effects/DelayEffect.cs | Refactors to create DelayNode directly instead of processor; updates properties to use CreateAnimatable |
| src/Beutl.Engine/Audio/Effects/AudioEffectProcessorGroup.cs | Removes processor group, replaced by Aggregate pattern in AudioEffectGroup |
| src/Beutl.Engine/Audio/Effects/AudioEffectGroup.cs | Simplifies effect chaining using LINQ Aggregate with new CreateNode pattern |
| src/Beutl.Engine/Audio/Effects/AudioEffect.cs | Changes base class API from CreateProcessor to CreateNode |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecate the
CreateEffectNodemethod in favor of the newCreateNodemethod for audio effects, enhancing the audio processing architecture. Replace theDelayEffectprocessor withDelayNode.Breaking changes
The
CreateEffectNodemethod is removed, and all references should be updated to useCreateNode.Fixed issues
No specific issues are fixed in this pull request.