fix: moved the OffsetPosition property to the Sound class to work correctly #1433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
No TODO comments were found. |
Contributor
Minimum allowed line rate is |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the audio system by moving the OffsetPosition property from the concrete SourceSound class to the abstract Sound base class. This change enables all sound types to support audio offset positioning, not just source sounds. The PR also integrates the offset functionality into the audio processing pipeline and includes improvements to the audio context's node lifecycle management.
- Moved
OffsetPositionproperty toSoundbase class for broader applicability - Integrated
ShiftNodeinto the audio processing chain to apply the offset - Removed overly restrictive validation that prevented negative time shifts (which are valid for offsetting audio backwards)
- Added cleanup logic in
AudioContext.EndUpdateto prevent reused nodes from retaining references to disposed nodes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Beutl.Engine/Audio/SourceSound.cs | Removed OffsetPosition property that has been moved to base class |
| src/Beutl.Engine/Audio/Sound.cs | Added OffsetPosition property and integrated ShiftNode into the audio processing pipeline |
| src/Beutl.Engine/Audio/Graph/AudioContext.cs | Removed validation preventing negative shifts, improved null-check pattern, and added cleanup logic to prevent dangling node references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking changes
Fixed issues