Implement the PathFollowEffect #1427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new PathFollowEffect that allows objects to follow a path with optional rotation, and enhances the GeometryEditor UI to support geometry initialization and type changes.
Key Changes
- Implements
PathFollowEffectwith properties for geometry, progress, and rotation following - Adds "Initialize" option in
GeometryEditorto set geometry toPathGeometrytype - Uncomments context flyout display logic in
GeometryEditor
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Beutl.Engine/Graphics/FilterEffects/PathFollowEffect.cs | New effect implementation for path following with geometry, progress, and rotation properties |
| src/Beutl/Views/Editors/GeometryEditor.axaml.cs | Adds InitializeClick method to initialize geometry type and uncomments flyout display logic |
| src/Beutl/Views/Editors/GeometryEditor.axaml | Adds UI menu item for geometry initialization |
| src/Beutl.Operators/LibraryRegistrar.cs | Registers the new PathFollowEffect in the effects library |
| src/Beutl.Language/Strings.resx | Adds English resource strings for new effect properties |
| src/Beutl.Language/Strings.ja.resx | Adds Japanese resource strings for new effect properties |
Files not reviewed (1)
- src/Beutl.Language/Strings.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
|
No TODO comments were found. |
Contributor
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce the
PathFollowEffectwith properties for geometry and progress, enhancing the effects available in the graphics engine. Additionally, add an option inGeometryEditorto initialize and change the geometry type.Breaking changes
None.
Fixed issues