feat: Support intermediate destinations using line topology#2
feat: Support intermediate destinations using line topology#2google-labs-jules[bot] wants to merge 2 commits intomainfrom
Conversation
- Implemented `LineTopology` helper to fetch ordered stop sequences from Navitia API. - Updated Config Flow to allow selecting any stop as a destination (Target Stop). - Updated Coordinator to filter trains based on whether they serve the Target Stop (topology check). - Removed reliance on dynamic destination discovery for initial configuration.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Review changes with Changed Files
|
- Implemented `LineTopology` helper to fetch ordered stop sequences from Navitia API. - Updated Config Flow to allow selecting any stop as a destination (Target Stop). - Updated Coordinator to filter trains based on whether they serve the Target Stop (topology check). - Removed reliance on dynamic destination discovery for initial configuration.
This PR introduces support for selecting intermediate stops as destinations (e.g., Vincennes -> Auber) by leveraging the Navitia API to understand line topology.
Changes:
custom_components/idfm/topology.pyto fetch and cache route stop sequences.This addresses the issue where users could only select final terminuses (e.g., Cergy) even if they alight earlier (e.g., Auber).
PR created automatically by Jules for task 7545709377014784176 started by @azman0101