Skip to content

⚡ Optimize regex creation in gemini service #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayush1920 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Optimize regex creation in gemini service #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions server/src/services/gemini.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,11 @@ export const processReceiptImage = async (
}
};

// Use regex with word boundaries to avoid false positives (e.g. "Coffee" matching "off")
// Optimization: Moved to module scope to prevent re-compilation on every function call
const DISCOUNT_REGEX = /\b(discount|savings?|coupon|promo|off|less)\b/i;
const ROUND_OFF_KEYWORDS = ['round off', 'rounding', 'roundoff', 'adjustment'];

/**
* rigorously validates and corrects the parsed receipt data.
* - Enforces negative signs for discounts.
Expand All @@ -169,19 +174,15 @@ export function sanitizeParsedData(data: any): any {
return 0;
};

// Use regex with word boundaries to avoid false positives (e.g. "Coffee" matching "off")
const discountRegex = /\b(discount|savings?|coupon|promo|off|less)\b/i;
const roundOffKeywords = ['round off', 'rounding', 'roundoff', 'adjustment'];

// 1. First Pass: Enforce Negative Signs on explicit Discounts
const enforceNegatives = (list: any[]) => {
if (!Array.isArray(list)) return;
list.forEach(item => {
const name = (item.name || '');
// Check if it's a discount, but IGNORE "Round Off" which might contain "off"
const isRoundOff = roundOffKeywords.some(k => name.toLowerCase().includes(k));
const isRoundOff = ROUND_OFF_KEYWORDS.some(k => name.toLowerCase().includes(k));

if (discountRegex.test(name) && !isRoundOff) {
if (DISCOUNT_REGEX.test(name) && !isRoundOff) {
// If price/amount is positive, flip it
if (item.price !== undefined && getVal(item.price) > 0) item.price = -getVal(item.price);
if (item.amount !== undefined && getVal(item.amount) > 0) item.amount = -getVal(item.amount);
Expand All @@ -207,7 +208,7 @@ export function sanitizeParsedData(data: any): any {
if (!Array.isArray(list)) return;
list.forEach(item => {
const name = (item.name || '').toLowerCase();
const isRoundOff = roundOffKeywords.some(k => name.includes(k));
const isRoundOff = ROUND_OFF_KEYWORDS.some(k => name.includes(k));
const val = getVal(item.price !== undefined ? item.price : item.amount);
const qty = getVal(item.quantity) || 1;

Expand Down