Skip to content

feat: Add ErrorPopover for Real-Time Regex Syntax Validation #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

jouchaib2020
Copy link

This update improves the regex learning journey by providing users with immediate syntax validation feedback, thereby enhancing the overall learning experience .

Changes

  • Introduced the ErrorPopover component to display regex syntax errors.
  • Implemented text color change from green to red when regex syntax is incorrect for real-time feedback on regex validity.
  • Utilizes the newly added error icon for clear error indication.

@aykutkardas
Copy link
Owner

Could you add a screenshot?

@jouchaib2020
Copy link
Author

jouchaib2020 commented Dec 11, 2024

Yes :)
image
image
image

@aykutkardas aykutkardas requested a review from Copilot April 9, 2025 09:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/components/Icon/selection.json: Language not supported
Comments suppressed due to low confidence (2)

src/utils/checkRegex.ts:11

  • The function name 'createGrouppedRegex' appears to have a misspelling; consider renaming it to 'createGroupedRegex' for clarity.
const createGrouppedRegex = (regex: string, flags?: string) => {

src/components/InteractiveArea.tsx:43

  • [nitpick] Consider renaming 'isvalidRegexSyntax' to 'isValidRegexSyntax' to adhere to standard camelCase naming conventions.
const [isvalidRegexSyntax, setIsvalidRegexSyntax] = useState(true);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants