light: syslog source #558
Merged
light: syslog source #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Szakacs <[email protected]>
Note: This change breaks the tests, but the next commit will fix it Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
When we configure auto transport to a source, Light cannot know what transport should be used to send a log to that source. For this I have also introduced a transport arg to write_log(). Signed-off-by: Attila Szakacs <[email protected]>
Similar to transport. Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
alltilla
force-pushed
the
light-syslog-source
branch
from
018790a to
e336c93
Compare
Signed-off-by: Attila Szakacs <[email protected]>
Signed-off-by: Attila Szakacs <[email protected]>
alltilla
force-pushed
the
light-syslog-source
branch
from
e336c93 to
9892b63
Compare
It is not intended to be used by the user, the correct way is to use log related functions. Signed-off-by: Attila Szakacs <[email protected]>
mitzkia
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had a
SyslogSource, but it did not send the logs with framing, so this PR fixes that.I also observed that the "log" entity all throughout Light is not separated well from some transport specific details, like
\ndelimiting in case of network and file drivers (\nwas considered part of the log, but it is in reality a delimiter in case of network and file sources), I also fixed these.