Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux and macOS, trying to run with the linkcheck plugin configured would error out with the following error:
This turns out to have been caused by us passing a relative path to the book directory instead of an absolute path. The relative path was fine for the main rendering process, but not the linkcheck plugin.
It appears that we intentionally made the path relative before passing it in here, but I'm not clear on why. It makes more sense in some of the "watching paths" route, but this path clearly works better as an absolute path. If we're happy with going with the absolute path, it probably makes sense to just join
book_path
toroot_path
instead of going throughpaths::determine_path()
.