Express api server tests

[nfreear]

Pull Request Template

PR Checklist

• I have run npm test locally and all tests are passing.
• I have added/updated tests for any new behavior.
• If this is a significant change, an issue has already been created where the problem / solution was discussed: Proposed PR :~ unit tests for 'express-api-server' #580.

PR Description

Hi @jesus-seijas-sp,

As discussed in #580, I've:

• Split the ExpressApiServer class in two;
• Add the supertest dev dependency;
• Added unit tests for the two classes;

I hope this helps.

Yours,

Nick

[coveralls]

Pull Request Test Coverage Report for Build 2051

• 24 of 25 (96.0%) changed or added relevant lines in 3 files are covered.
• 40 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.5%) to 74.428%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/express-api-server/src/express-api-server.js	4	5	80.0%

Files with Coverage Reduction	New Missed Lines	%
packages/express-api-server/src/express-api-server.js	2	82.93%
packages/nlg/src/nlg-manager.js	4	91.98%
packages/nlp/src/nlp.js	34	50.1%

Totals
Change from base Build 1244:	0.5%
Covered Lines:	6251
Relevant Lines:	8018

---

💛 - Coveralls

[nfreear]

Hi @jesus-seijas-sp,

I'm happy to say, this is now ready to merge.

Note, the supertest is a dev-dependency in two places:

1. ./package.json -- For the jest unit tests (preferred location);
2. ./packages/api-express-server/package.json -- To pass eslint test;

(Is there a way we can remove the second inclusion?)

Ta,

Nick

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 5 Security Hotspots to review)
0 Code Smells

No Coverage information
0.3% Duplication