Skip to content

Conversation

jamesbornholt
Copy link
Member

@jamesbornholt jamesbornholt commented Nov 18, 2022

track_caller is unstable and seems to now be guarded behind a feature flag: rust-lang/rust#74042

We also have one test for large objects that is very slow under ASan.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

lukenels
lukenels previously approved these changes Nov 18, 2022
Copy link
Contributor

@lukenels lukenels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jamesbornholt jamesbornholt changed the title Remove track_caller from async function Fixes for address sanitizer build Nov 18, 2022
lukenels
lukenels previously approved these changes Nov 18, 2022
Copy link
Contributor

@lukenels lukenels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 2

track_caller is unstable and seems to now be guarded behind a feature flag:
rust-lang/rust#74042

We also have one test for large objects that is very slow under ASan.
Copy link
Contributor

@lukenels lukenels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 3

@jamesbornholt jamesbornholt merged commit e257d71 into main Nov 18, 2022
@jamesbornholt jamesbornholt deleted the track-caller branch November 22, 2022 01:53
c-hagem added a commit to c-hagem/mountpoint-s3 that referenced this pull request Jul 1, 2025
# This is the 1st commit message:

add metablock

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#2:

Introduce more generic lookedup

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#3:

Use Arc to store identical bucket + prefix combination

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#4:

include bucket in inode error info

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#5:

delta

# This is the commit message awslabs#6:

continue

# This is the commit message awslabs#7:

Remove LookedUp from DirectoryReply

Signed-off-by: Christian Hagemeier <[email protected]>

Remove weird error handling hack

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#8:

Update readdir implementation

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#9:

start removing LookedUpWithInode

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#10:

remove LookedUpWithInode from public methods in superblock

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#11:

fix public getattr

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#12:

remove unsafe

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#13:

fix memory leak

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#14:

readdir handle

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#15:

clone arc to remove getting mutex multiple times

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#16:

simplify readdir(plus) handling in fs

# This is the commit message awslabs#17:

simplify readdir interface

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#18:

remove stuff

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#19:

further readability improvements

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#20:

fix build

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#21:

remove duplicate hashmap

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#22:

revert to old readdir implementation

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#23:

remove test

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#24:

add path to lookedupinode

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#25:

derive debug for superblock

Signed-off-by: Christian Hagemeier <[email protected]>

# This is the commit message awslabs#26:

small change

Signed-off-by: Christian Hagemeier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants