-
Notifications
You must be signed in to change notification settings - Fork 212
Fixes for address sanitizer build #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
315af50
to
b297a7e
Compare
b297a7e
to
dfe1196
Compare
lukenels
previously approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dfe1196
to
c0f10d9
Compare
lukenels
previously approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2
c0f10d9
to
260be57
Compare
track_caller is unstable and seems to now be guarded behind a feature flag: rust-lang/rust#74042 We also have one test for large objects that is very slow under ASan.
260be57
to
fb36700
Compare
lukenels
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3
c-hagem
added a commit
to c-hagem/mountpoint-s3
that referenced
this pull request
Jul 1, 2025
# This is the 1st commit message: add metablock Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#2: Introduce more generic lookedup Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#3: Use Arc to store identical bucket + prefix combination Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#4: include bucket in inode error info Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#5: delta # This is the commit message awslabs#6: continue # This is the commit message awslabs#7: Remove LookedUp from DirectoryReply Signed-off-by: Christian Hagemeier <[email protected]> Remove weird error handling hack Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#8: Update readdir implementation Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#9: start removing LookedUpWithInode Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#10: remove LookedUpWithInode from public methods in superblock Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#11: fix public getattr Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#12: remove unsafe Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#13: fix memory leak Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#14: readdir handle Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#15: clone arc to remove getting mutex multiple times Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#16: simplify readdir(plus) handling in fs # This is the commit message awslabs#17: simplify readdir interface Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#18: remove stuff Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#19: further readability improvements Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#20: fix build Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#21: remove duplicate hashmap Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#22: revert to old readdir implementation Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#23: remove test Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#24: add path to lookedupinode Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#25: derive debug for superblock Signed-off-by: Christian Hagemeier <[email protected]> # This is the commit message awslabs#26: small change Signed-off-by: Christian Hagemeier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
track_caller
is unstable and seems to now be guarded behind a feature flag: rust-lang/rust#74042We also have one test for large objects that is very slow under ASan.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.