Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network config to all component benchmarks #1284

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dannycjones
Copy link
Contributor

This change introduces both the CRT's target network throughput configuration and the network interface configuration to each of the benchmarks for layers/components in Mountpoint's read path.

These are added primarily to support performance investigations, so we can identify where there are gaps in performance and narrow them to improve throughput of Mountpoint overall.

The target throughput default of 10.0 Gbps is removed on the lowest level of the benchmark, given we don't know what the default is for the CRT itself. It is left in place on all other layers as we default the value to 10.0 Gbps inside Mountpoint's S3 client.

Does this change impact existing behavior?

No, adds new arguments to benchmark scripts only. Even in those scripts, we alias any command line arguments that change.

Does this change need a changelog entry? Does it require a version change?

No, this is benchmarking changes only.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@dannycjones dannycjones temporarily deployed to PR integration tests February 25, 2025 06:19 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 25, 2025 06:19 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 25, 2025 06:19 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 25, 2025 06:19 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 25, 2025 06:19 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 25, 2025 06:19 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 25, 2025 06:19 — with GitHub Actions Inactive
@dannycjones dannycjones marked this pull request as draft February 28, 2025 10:45
auto-merge was automatically disabled February 28, 2025 10:45

Pull request was converted to draft

@dannycjones dannycjones temporarily deployed to PR integration tests February 28, 2025 10:52 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 28, 2025 10:52 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 28, 2025 10:52 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 28, 2025 10:52 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 28, 2025 10:52 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 28, 2025 10:52 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 28, 2025 10:52 — with GitHub Actions Inactive
@dannycjones dannycjones force-pushed the further-prefetch-benchmark-update branch from fdfca13 to 038d89f Compare February 28, 2025 14:10
@dannycjones dannycjones force-pushed the further-prefetch-benchmark-update branch from 038d89f to 146cd79 Compare February 28, 2025 14:11
@dannycjones dannycjones temporarily deployed to PR integration tests February 28, 2025 14:11 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 28, 2025 14:11 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 28, 2025 14:11 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 28, 2025 14:11 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 28, 2025 14:11 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 28, 2025 14:11 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests February 28, 2025 14:11 — with GitHub Actions Inactive
@dannycjones dannycjones marked this pull request as ready for review February 28, 2025 15:07
@dannycjones dannycjones force-pushed the further-prefetch-benchmark-update branch from 146cd79 to 5daf29b Compare March 4, 2025 17:46
@dannycjones dannycjones temporarily deployed to PR integration tests March 4, 2025 17:46 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 4, 2025 17:46 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 4, 2025 17:46 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 4, 2025 17:46 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 4, 2025 17:46 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 4, 2025 17:46 — with GitHub Actions Inactive
@dannycjones dannycjones temporarily deployed to PR integration tests March 4, 2025 17:46 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant