Get default Mountpoint namespace from env in CSI Controller #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Burak Varlı <[email protected]>
muddyfish
reviewed
Jan 31, 2025
| @@ -22,7 +22,7 @@ import ( | |||
| "github.com/awslabs/aws-s3-csi-driver/pkg/podmounter/mppod" | |||
| ) | |||
|
|
|||
| var mountpointNamespace = flag.String("mountpoint-namespace", "mount-s3", "Namespace to spawn Mountpoint Pods in.") | |||
| var mountpointNamespace = flag.String("mountpoint-namespace", os.Getenv("MOUNTPOINT_NAMESPACE"), "Namespace to spawn Mountpoint Pods in.") | |||
There was a problem hiding this comment.
Shouldn't we also include an update to set this variable in this PR as well?
There was a problem hiding this comment.
It's in an upcoming commit here 57b5699#diff-0ea7410c82938b74ea30e5de3a925389ed5ab54bcaa447f3e59248faa1ae2f93R69-R70. I just wanted to send small unrelated changes first to not have a similar problem as #328
There was a problem hiding this comment.
So currently this code isn't used right?
There was a problem hiding this comment.
Yes, this binary isn't even installed in our Docker images yet, which will be with #364, and then the previously shared commit will add Kubernetes manifest to use this binary. We only run tests for this component yet
muddyfish
approved these changes
Feb 3, 2025
unexge
deleted the
csi-controller-get-mountpoint-namespace-from-env-by-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have consistency with other options and to ensure we don't hard-code Mountpoint namespace, get it from
MOUNTPOINT_NAMESPACEenv by default.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.