Add CSI Driver version label to Mountpoint pods #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renanmagagnin
requested a deployment
to
approval-gate
GitHub Actions
Waiting
dannycjones
reviewed
Jan 24, 2025
unexge
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Could you also update controller tests to assert this please?
Signed-off-by: Renan Magagnin <[email protected]>
renanmagagnin
force-pushed
the
feature/add-csi-driver-version-label-to-mountpoint-pods
branch
from
2d2cfac to
18d83da
Compare
renanmagagnin
requested a deployment
to
approval-gate
GitHub Actions
Waiting
Signed-off-by: Renan Magagnin <[email protected]>
renanmagagnin
temporarily deployed
to
approval-gate
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
approval-gate
GitHub Actions
Inactive
unexge
approved these changes
Jan 27, 2025
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
temporarily deployed
to
untrusted
GitHub Actions
Inactive
renanmagagnin
had a problem deploying
to
untrusted
GitHub Actions
Failure
renanmagagnin
deleted the
feature/add-csi-driver-version-label-to-mountpoint-pods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We currently add Mountpoint version, Pod UID and Volume Name as labels to Mountpoint Pod. These labels are useful to query Mountpoint Pods, for example one can run
kubectl get pods -n mount-s3 -ls3.csi.aws.com/mountpoint-version=1.11.0to get Mountpoint Pods using Mountpoint v1.11.0.In this PR, we add the CSI Driver's version as a new label. The Pod creator gets CSI Driver version from a new environment variable which is propagated throughout the call chain. Unit tests and integrations tests were also updated accordingly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.