Create a shorter symlink for Unix socket in mountoptions package
#346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go returns `invalid argument` if you try to `net.{Dial, Listen}` on a
Unix socket if the path is longer than 108 characters.
This limitation is only to the argument passed to those functions, if
we receive a Unix socket path longer than 108 characters, we create a
symlink for that path in tempdir for that platform and use that path
in network operations to workaround this limitation.
Signed-off-by: Burak Varlı <[email protected]>
unexge
had a problem deploying
to
approval-gate
GitHub Actions
Failure
|
Can we add a test for this? |
|
Originally there were tests for this functionality in |
Signed-off-by: Burak Varlı <[email protected]>
|
Added tests with 8f044d4 |
muddyfish
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go returns
invalid argumentif you try tonet.{Dial, Listen}on a Unix socket if the path is longer than 108 characters.This limitation is only to the argument passed to those functions, if we receive a Unix socket path longer than 108 characters, we create a symlink for that path in temporary dir for that platform and use that path in network operations to work around this limitation.
We were just omitting a warning before, but it'd be hard to work around this limitation on the caller side, so that warning wouldn't be much actionable.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.